Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove move cell integration test #156825

Merged
merged 3 commits into from
Aug 1, 2022

Conversation

rebornix
Copy link
Member

@rebornix rebornix commented Aug 1, 2022

Move Cell logic is being well tested through unit tests and extension host document update is being tested through notebook.document.test, thus removing our own move cell command integration test.

@rebornix rebornix enabled auto-merge (squash) August 1, 2022 18:44
@rebornix rebornix self-assigned this Aug 1, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the August 2022 milestone Aug 1, 2022
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend not doing non-null assertions as it can come back and bite us. Assert that they are non null in the test via assert.ok

@rebornix rebornix requested a review from lramos15 August 1, 2022 19:05
lramos15
lramos15 previously approved these changes Aug 1, 2022
@rebornix rebornix merged commit f31a88e into main Aug 1, 2022
@rebornix rebornix deleted the rebornix/remove-move-cell-integration-test branch August 1, 2022 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants