Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable task reconnection by default and fix for windows #156909

Merged
merged 10 commits into from Aug 3, 2022
Expand Up @@ -351,6 +351,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
private async _reconnectTasks(): Promise<void> {
const tasks = await this.getSavedTasks('persistent');
if (!tasks.length) {
this._tasksReconnected = true;
return;
}
for (const task of tasks) {
Expand Down Expand Up @@ -1067,7 +1068,7 @@ export abstract class AbstractTaskService extends Disposable implements ITaskSer
}

private async _setPersistentTask(task: Task): Promise<void> {
if (!task.configurationProperties.isBackground || !this._tasksReconnected) {
if (!task.configurationProperties.problemMatchers || !this._tasksReconnected) {
return;
}
let key = task.getRecentlyUsedKey();
Expand Down
5 changes: 2 additions & 3 deletions src/vs/workbench/contrib/tasks/browser/task.contribution.ts
Expand Up @@ -515,9 +515,8 @@ configurationRegistry.registerConfiguration({
},
[TaskSettingId.Reconnection]: {
type: 'boolean',
description: nls.localize('task.experimental.reconnection', "On window reload, reconnect to running watch/background tasks. Note that this is experimental, so you could encounter issues."),
default: false,
tags: ['experimental']
description: nls.localize('task.reconnection', "On window reload, reconnect to tasks that have problem matchers."),
default: true
},
[TaskSettingId.SaveBeforeRun]: {
markdownDescription: nls.localize(
Expand Down