-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform URIs of hover results #157448
base: main
Are you sure you want to change the base?
Transform URIs of hover results #157448
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The uri transformer shouldn't be used directly. The contract is that the at the level of the RPC protocol uri transformation happens - for any URI instance (which is the reason why some "funny" uri extraction happens for markdown)
Can you add some detail what issue you are trying to solve and what repro steps show this? It might be a case of missing to extract a particular uri
Thank you for kind reply~ I want to fix URIs' rendered inside hover results because they seem to point to local file system Kapture.2022-08-17.at.14.03.58.mp4As you can see in the above clip, Could you give me some insights on how to fix this issue without breaking the contract? :) |
trying to (partially) fix #157124 with unit tests
file://
andvscode-local://
URIs provided byHoverProvider
s are now transformed andMarkdownRenderer
will render the transformed URI