Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid corrupting stored image data in edit sessions #157582

Merged
merged 3 commits into from
Aug 8, 2022
Merged

Avoid corrupting stored image data in edit sessions #157582

merged 3 commits into from
Aug 8, 2022

Commits on Aug 8, 2022

  1. Support images in edit sessions by base64 encoding file contents

    @joyceerhl
    joyceerhl committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    af87992 View commit details
    Browse the repository at this point in the history

  2. Allow read operations for file system providers implementing readFile

    @joyceerhl
    joyceerhl committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    cd477d6 View commit details
    Browse the repository at this point in the history

  3. Update edit session view to show decoded working changes 

    Previously edit sessions only accounted for text files, so a `TextModelContentProvider` was sufficient, but now we need to register a file system provider because image data is handled by extensions and we don't own the model for that
    @joyceerhl
    joyceerhl committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    950d210 View commit details
    Browse the repository at this point in the history