Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Icons and Header Separators to Code Action Widget #157687

Merged
merged 42 commits into from
Aug 11, 2022

Conversation

justschen
Copy link
Contributor

@justschen justschen marked this pull request as ready for review August 11, 2022 17:43
@justschen justschen requested a review from mjbvz August 11, 2022 17:43
@VSCodeTriageBot VSCodeTriageBot added this to the August 2022 milestone Aug 11, 2022
@justschen justschen enabled auto-merge (squash) August 11, 2022 23:35
@justschen justschen merged commit 8e456bd into microsoft:main Aug 11, 2022
@DanTup
Copy link
Contributor

DanTup commented Aug 14, 2022

FWIW, I think refactors that don't match one of VS Code's known categories might be going missing (it looks like they're added to an "other" group in the code, but I think they're going missing because there's on else/other case here?

if (CodeActionKind.SurroundWith.contains(new CodeActionKind(String(firstAction)))) {

This was reported at Dart-Code/Dart-Code#4104. I've advised the poster to file an issue here since I don't think it's intended that refactors must match one of these groups (although, some of those missing in this case could be mapped to SurroundWith, which I'll take a look at).

@justschen
Copy link
Contributor Author

@DanTup That's a great catch - I had removed an initial code snippet which included 'other' code actions that wouldn't be captured, but added in additional checks for source actions, etc.

Will take a look at this immediately!

@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants