Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pasting image into newly created cell bug #158404

Merged
merged 5 commits into from
Aug 23, 2022
Merged

fix pasting image into newly created cell bug #158404

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
880fda6
fix pasting image into newly created cell bug
Aug 17, 2022
6f7189b
refactor metadata into own fxn
Aug 18, 2022
5190823
Merge branch 'main' into mlively/newCellPasteBug
Aug 18, 2022
771b865
Merge branch 'main' into mlively/newCellPasteBug
Aug 18, 2022
1076180
Merge branch 'main' into mlively/newCellPasteBug
Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 11 additions & 3 deletions extensions/ipynb/src/notebookImagePaste.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,17 @@ class CopyPasteEditProvider implements vscode.DocumentPasteEditProvider {

// create updated metadata for cell (prep for WorkspaceEdit)
const b64string = encodeBase64(fileDataAsUint8);
const startingAttachments = currentCell.metadata?.custom?.attachments;
const startingAttachments = currentCell.metadata.custom?.attachments;
Yoyokrazy marked this conversation as resolved.
Show resolved Hide resolved
let metadataNotebookEdit;
if (!startingAttachments) {
currentCell.metadata.custom['attachments'] = { [pasteFilename]: { 'image/png': b64string } };
if (!currentCell.metadata.custom) {
const initMetadata = { 'custom': { 'attachments': { [pasteFilename]: { 'image/png': b64string } } } };
metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, initMetadata);
} else {
currentCell.metadata.custom['attachments'] = { [pasteFilename]: { 'image/png': b64string } };
metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, currentCell.metadata);
}

} else {
for (let appendValue = 2; pasteFilename in startingAttachments; appendValue++) {
const objEntries = Object.entries(startingAttachments[pasteFilename]);
Expand All @@ -76,9 +84,9 @@ class CopyPasteEditProvider implements vscode.DocumentPasteEditProvider {
}
}
currentCell.metadata.custom.attachments[pasteFilename] = { 'image/png': b64string };
metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, currentCell.metadata);
}

const metadataNotebookEdit = vscode.NotebookEdit.updateCellMetadata(currentCell.index, currentCell.metadata);
Yoyokrazy marked this conversation as resolved.
Show resolved Hide resolved
const workspaceEdit = new vscode.WorkspaceEdit();
if (metadataNotebookEdit) {
workspaceEdit.set(notebookUri, [metadataNotebookEdit]);
Expand Down