Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run oss tool #158934

Merged
merged 1 commit into from
Aug 23, 2022
Merged

run oss tool #158934

merged 1 commit into from
Aug 23, 2022

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Aug 23, 2022

No description provided.

@mjbvz mjbvz added this to the August 2022 milestone Aug 23, 2022
@mjbvz mjbvz self-assigned this Aug 23, 2022
@mjbvz mjbvz enabled auto-merge (squash) August 23, 2022 16:57
@isidorn
Copy link
Contributor

isidorn commented Aug 23, 2022

Looks great. Fyi @deepak1556

@mjbvz mjbvz merged commit dcc2652 into microsoft:main Aug 23, 2022
@deepak1556
Copy link
Contributor

@mjbvz was the licenseDetail section to ffmpeg added by the OSS tool ? If so, we should find a way to remove that. The tool has picked up the contents of this file https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/refs/heads/master/LICENSE.md which is not the actual license of ffmpeg but rather license description added by chromium depending on how one builds ffmpeg and what license should be picked up.

In our case, we build ffmpeg with only LGPL-2.1+ components and no GPL code was included. Our license, should just be https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/refs/heads/master/COPYING.LGPLv2.1 . Doesn't our OSS tool consider "license": "LGPL-2.1+" as valid, what are the accepted license values ?

@mjbvz
Copy link
Collaborator Author

mjbvz commented Aug 24, 2022

@deepak1556 Thanks for the info. The tool told me to add this so I copied in the text manually. I'll update the license text to point to that file instead

mjbvz added a commit to mjbvz/vscode that referenced this pull request Aug 24, 2022
microsoft#158934 (comment)

The oss tool keeps saying tthis is required
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants