Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: review slow running early workbench contributions #159675

Closed
7 tasks done
bpasero opened this issue Aug 31, 2022 · 2 comments
Closed
7 tasks done

Perf: review slow running early workbench contributions #159675

bpasero opened this issue Aug 31, 2022 · 2 comments

Comments

@bpasero
Copy link
Member

bpasero commented Aug 31, 2022

Refs: #156864

I instrumented slow running code that executes via registerWorkbenchContribution at an early stage before editors restore. In devtools you will see a warning in case the contribution needs more than 5ms being instantiated:

image

The time we spend here is time we take away from the user before the editor contents appear, thus we block the critical startup path.

I did some experiments from a custom build that includes this change on platforms and found some contributions that constantly appeared with above 5ms construction times.

Task

  • use devtools profiling to see if there is a low hanging fruit to improve performance
  • review if the contribution could run at a later phase, e.g. LifecyclePhase.Restored or even LifecyclePhase.Eventually

List

@bpasero bpasero added this to the September 2022 milestone Aug 31, 2022
@rzhao271 rzhao271 removed their assignment Aug 31, 2022
@aeschli aeschli removed their assignment Sep 1, 2022
@rebornix rebornix removed their assignment Sep 1, 2022
sandy081 added a commit that referenced this issue Sep 2, 2022
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Sep 2, 2022
@bpasero bpasero reopened this Sep 2, 2022
@VSCodeTriageBot VSCodeTriageBot removed the unreleased Patch has not yet been released in VS Code Insiders label Sep 2, 2022
@bpasero
Copy link
Member Author

bpasero commented Sep 2, 2022

Thanks!

@bpasero bpasero closed this as completed Sep 2, 2022
@rzhao271
Copy link
Contributor

rzhao271 commented Sep 7, 2022

Due to #159875, I'd like to split PreferencesActionsContribution into smaller sets of contributions, because some parts, such as the button that brings the user from the Settings UI to the Current Profile Settings JSON, can probably be contributed later than others.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants