Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate RemoteEmptyWorkbenchPresentation on LifecyclePhase.Ready. For #159675 #159762

Merged
merged 1 commit into from Sep 1, 2022

Conversation

aeschli
Copy link
Contributor

@aeschli aeschli commented Sep 1, 2022

I tested that chaning to ready works.

To verify:

  • set "workbench.startupEditor": "newUntitledFile"
  • open a remote window from the command line

e.g. /scripts/code.sh -remote=test+test -n

The file explorer should open

@aeschli aeschli self-assigned this Sep 1, 2022
@bpasero
Copy link
Member

bpasero commented Sep 1, 2022

Note that Ready will also block an editor from restoring. But I really did not see this contribution showing up often as blocking more than 5ms, just once. It maybe a red herring. Best to review the contribution if there is any code in there that is potentially long running.

@aeschli aeschli merged commit 4a31932 into main Sep 1, 2022
@aeschli aeschli deleted the aeschli/159675 branch September 1, 2022 14:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants