Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding brace completion for snippet inline completion item #160567

Merged
merged 1 commit into from
Sep 22, 2022
Merged

adding brace completion for snippet inline completion item #160567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/vs/editor/contrib/inlineCompletions/browser/inlineCompletionsModel.ts
View file
Open in desktop
Expand Up @@ -734,8 +734,26 @@ export async function provideInlineCompletions(

snippetInfo = undefined;
} else if ('snippet' in item.insertText) {
const preBracketCompletionLength = item.insertText.snippet.length;

if (languageConfigurationService && item.completeBracketPairs) {
item.insertText.snippet = closeBrackets(
item.insertText.snippet,
range.getStartPosition(),
model,
languageConfigurationService
);

// Modify range depending on if brackets are added or removed
const diff = item.insertText.snippet.length - preBracketCompletionLength;
if (diff !== 0) {
range = new Range(range.startLineNumber, range.startColumn, range.endLineNumber, range.endColumn + diff);
}
}

const snippet = new SnippetParser().parse(item.insertText.snippet);
insertText = snippet.toString();

snippetInfo = {
snippet: item.insertText.snippet,
range: range
Expand Down