Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CodeActionKind.RefactorMove #160730

Merged
merged 1 commit into from Sep 12, 2022
Merged

Add CodeActionKind.RefactorMove #160730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/typescript-language-features/src/languageFeatures/refactor.ts
View file
Open in desktop
Expand Up @@ -135,7 +135,7 @@ const Extract_Interface = Object.freeze<CodeActionKind>({
});

const Move_NewFile = Object.freeze<CodeActionKind>({
kind: vscode.CodeActionKind.Refactor.append('move').append('newFile'),
kind: vscode.CodeActionKind.RefactorMove.append('newFile'),
matches: refactor => refactor.name.startsWith('Move to a new file')
});

Expand Down
1 change: 1 addition & 0 deletions extensions/vscode-api-tests/src/singlefolder-tests/types.test.ts
View file
Open in desktop
Expand Up @@ -20,6 +20,7 @@ suite('vscode API - types', () => {
assert.ok(vscode.CodeActionKind.Refactor instanceof vscode.CodeActionKind);
assert.ok(vscode.CodeActionKind.RefactorExtract instanceof vscode.CodeActionKind);
assert.ok(vscode.CodeActionKind.RefactorInline instanceof vscode.CodeActionKind);
assert.ok(vscode.CodeActionKind.RefactorMove instanceof vscode.CodeActionKind);
assert.ok(vscode.CodeActionKind.RefactorRewrite instanceof vscode.CodeActionKind);
assert.ok(vscode.CodeActionKind.Source instanceof vscode.CodeActionKind);
assert.ok(vscode.CodeActionKind.SourceOrganizeImports instanceof vscode.CodeActionKind);
Expand Down
2 changes: 2 additions & 0 deletions src/vs/workbench/api/common/extHostTypes.ts
View file
Open in desktop
Expand Up @@ -1321,6 +1321,7 @@ export class CodeActionKind {
public static Refactor: CodeActionKind;
public static RefactorExtract: CodeActionKind;
public static RefactorInline: CodeActionKind;
public static RefactorMove: CodeActionKind;
public static RefactorRewrite: CodeActionKind;
public static Source: CodeActionKind;
public static SourceOrganizeImports: CodeActionKind;
Expand All @@ -1347,6 +1348,7 @@ CodeActionKind.QuickFix = CodeActionKind.Empty.append('quickfix');
CodeActionKind.Refactor = CodeActionKind.Empty.append('refactor');
CodeActionKind.RefactorExtract = CodeActionKind.Refactor.append('extract');
CodeActionKind.RefactorInline = CodeActionKind.Refactor.append('inline');
CodeActionKind.RefactorMove = CodeActionKind.Refactor.append('move');
CodeActionKind.RefactorRewrite = CodeActionKind.Refactor.append('rewrite');
CodeActionKind.Source = CodeActionKind.Empty.append('source');
CodeActionKind.SourceOrganizeImports = CodeActionKind.Source.append('organizeImports');
Expand Down
13 changes: 12 additions & 1 deletion src/vscode-dts/vscode.d.ts
View file
Open in desktop
Expand Up @@ -2275,6 +2275,18 @@ declare module 'vscode' {
*/
static readonly RefactorInline: CodeActionKind;

/**
* Base kind for refactoring move actions: `refactor.move`
*
* Example move actions:
*
* - Move a function to a new file
* - Move a property between classes
* - Move method to base class
* - ...
*/
static readonly RefactorMove: CodeActionKind;

/**
* Base kind for refactoring rewrite actions: `refactor.rewrite`
*
Expand All @@ -2284,7 +2296,6 @@ declare module 'vscode' {
* - Add or remove parameter
* - Encapsulate field
* - Make method static
* - Move method to base class
* - ...
*/
static readonly RefactorRewrite: CodeActionKind;
Expand Down