Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't register git protocol handler till after git commands are registered #160857

Merged
merged 2 commits into from Sep 14, 2022
Merged

Don't register git protocol handler till after git commands are registered #160857

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5216cd2
Don't register git protocol handler till after git commands are regis…
joyceerhl Sep 13, 2022
c47bbb3
Merge branch 'main' into dev/joyceerhl/productive-lobster
joyceerhl Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions extensions/git/src/main.ts
View file
Open in desktop
Expand Up @@ -182,8 +182,6 @@ export async function _activate(context: ExtensionContext): Promise<GitExtension
const outputChannelLogger = new OutputChannelLogger();
disposables.push(outputChannelLogger);

disposables.push(new GitProtocolHandler(outputChannelLogger));

const { name, version, aiKey } = require('../package.json') as { name: string; version: string; aiKey: string };
const telemetryReporter = new TelemetryReporter(name, version, aiKey);
deactivateTasks.push(() => telemetryReporter.dispose());
Expand Down Expand Up @@ -222,6 +220,8 @@ export async function _activate(context: ExtensionContext): Promise<GitExtension
warnAboutMissingGit();

return new GitExtensionImpl();
} finally {
disposables.push(new GitProtocolHandler(outputChannelLogger));
}
}

Expand Down