Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add basic contextual commands #160952

Merged
merged 48 commits into from
Sep 22, 2022
Merged

add basic contextual commands #160952

merged 48 commits into from
Sep 22, 2022

Conversation

meganrogge
Copy link
Contributor

@meganrogge meganrogge commented Sep 15, 2022 •
edited
Loading

fixes #151937

@meganrogge @Tyriar
start working on freeing a port
531da80 
Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge meganrogge marked this pull request as draft September 15, 2022 02:16
@meganrogge meganrogge self-assigned this Sep 15, 2022
@meganrogge meganrogge added this to the September 2022 milestone Sep 15, 2022
Tyriar
Tyriar previously requested changes Sep 20, 2022
View reviewed changes
src/vs/platform/terminal/common/capabilities/capabilities.ts Outdated Show resolved Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts Outdated Show resolved Hide resolved
src/vs/platform/terminal/common/capabilities/commandDetectionCapability.ts Outdated Show resolved Hide resolved
src/vs/platform/terminal/common/terminal.ts Show resolved Hide resolved
src/vs/platform/terminal/node/ptyService.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalActions.ts Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalBaseContextualActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalBaseContextualActions.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/terminalInstance.ts Outdated Show resolved Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/contextualActionAddon.ts Outdated Show resolved Hide resolved
meganrogge and others added 7 commits September 20, 2022 14:44
@meganrogge
clean up tests
8061f20
@meganrogge @Tyriar
Update src/vs/platform/terminal/common/capabilities/commandDetectionC…
cc0b50c 
…apability.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge @Tyriar
Update src/vs/platform/terminal/common/capabilities/commandDetectionC…
8a7c056 
…apability.ts

Co-authored-by: Daniel Imms <2193314+Tyriar@users.noreply.github.com>
@meganrogge
cleanup
ca074b4
@meganrogge
more test polish
7420e5f
@meganrogge
more cleanup
c94e479
@meganrogge
add run command action
99b5963
@meganrogge meganrogge marked this pull request as ready for review September 20, 2022 23:56
@meganrogge meganrogge changed the title wip: contextual commands add basic contextual commands Sep 20, 2022
@meganrogge
Copy link
Contributor Author

Just need to test on windows

@meganrogge meganrogge dismissed Tyriar’s stale review September 21, 2022 22:36

addressed feedback

@meganrogge
Copy link
Contributor Author

meganrogge commented Sep 22, 2022 •
edited
Loading

couldn't test using server launcher on windows because the command doesn't finish when the port is already in use (perhaps it should, maybe a bug)?

port

since I couldn't get xterm.js to build, @Tyriar can you pls try this on windows to make sure it works?

@meganrogge meganrogge merged commit de450f9 into main Sep 22, 2022
@meganrogge meganrogge deleted the merogge/context-commands branch September 22, 2022 22:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@meganrogge meganrogge

Labels
None yet
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

Explore contextual actions in the terminal
2 participants
@meganrogge @Tyriar