Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests - do not retryCountOnTaskFailure playwright #161299

Merged
merged 2 commits into from Sep 20, 2022
Merged

tests - do not retryCountOnTaskFailure playwright #161299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbdefe1
tests - do not `retryCountOnTaskFailure` playwright
bpasero Sep 20, 2022
e78913e
compile
bpasero Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -69,7 +69,7 @@ jobs:
7z.exe a .build/node_modules_cache/cache.7z -mx3 `@.build/node_modules_list.txt

- name: Compile and Download
run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions

- name: Compile Integration Tests
run: yarn --cwd test/integration/browser compile
Expand Down Expand Up @@ -145,7 +145,7 @@ jobs:
run: yarn --frozen-lockfile --network-timeout 180000

- name: Compile and Download
run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions

- name: Compile Integration Tests
run: yarn --cwd test/integration/browser compile
Expand Down Expand Up @@ -216,7 +216,7 @@ jobs:
run: yarn --frozen-lockfile --network-timeout 180000

- name: Compile and Download
run: DEBUG=pw:install yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions
run: yarn npm-run-all --max_old_space_size=4095 -lp compile "electron x64" playwright-install download-builtin-extensions

- name: Compile Integration Tests
run: yarn --cwd test/integration/browser compile
Expand Down Expand Up @@ -289,7 +289,7 @@ jobs:
run: yarn --frozen-lockfile --network-timeout 180000

- name: Download Playwright
run: DEBUG=pw:install yarn playwright-install
run: yarn playwright-install

- name: Run Hygiene Checks
run: yarn gulp hygiene
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/monaco-editor.yml
View file
Open in desktop
Expand Up @@ -53,7 +53,7 @@ jobs:
run: yarn --frozen-lockfile --network-timeout 180000

- name: Download Playwright
run: DEBUG=pw:install yarn playwright-install
run: yarn playwright-install

- name: Run Monaco Editor Checks
run: yarn monaco-compile-check
Expand Down
1 change: 1 addition & 0 deletions build/azure-pipelines/common/installPlaywright.js
View file
Open in desktop
Expand Up @@ -4,6 +4,7 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
Object.defineProperty(exports, "__esModule", { value: true });
process.env.DEBUG = 'pw:install'; // enable logging for this (https://github.com/microsoft/playwright/issues/17394)
const retry_1 = require("./retry");
const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server');
async function install() {
Expand Down
2 changes: 2 additions & 0 deletions build/azure-pipelines/common/installPlaywright.ts
View file
Open in desktop
Expand Up @@ -3,6 +3,8 @@
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/

process.env.DEBUG='pw:install'; // enable logging for this (https://github.com/microsoft/playwright/issues/17394)

import { retry } from './retry';
const { installDefaultBrowsersForNpmInstall } = require('playwright-core/lib/server');

Expand Down
4 changes: 1 addition & 3 deletions build/azure-pipelines/darwin/product-build-darwin-test.yml
View file
Open in desktop
Expand Up @@ -12,9 +12,7 @@ steps:
- script: |
set -e
VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
DEBUG=pw:install yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
timeoutInMinutes: 5
retryCountOnTaskFailure: 3
yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
displayName: Download Electron and Playwright

- ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}:
Expand Down
4 changes: 1 addition & 3 deletions build/azure-pipelines/linux/product-build-linux-client-test.yml
View file
Open in desktop
Expand Up @@ -12,9 +12,7 @@ steps:
- script: |
set -e
VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)" \
DEBUG=pw:install yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
timeoutInMinutes: 5
retryCountOnTaskFailure: 3
yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install"
displayName: Download Electron and Playwright

- ${{ if eq(parameters.VSCODE_QUALITY, 'oss') }}:
Expand Down
4 changes: 1 addition & 3 deletions build/azure-pipelines/win32/product-build-win32-test.yml
View file
Open in desktop
Expand Up @@ -13,9 +13,7 @@ steps:
. build/azure-pipelines/win32/exec.ps1
$ErrorActionPreference = "Stop"
$env:VSCODE_MIXIN_PASSWORD="$(github-distro-mixin-password)"
exec { $env:DEBUG = "pw:install"; yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" }
timeoutInMinutes: 5
retryCountOnTaskFailure: 3
exec { yarn npm-run-all -lp "electron $(VSCODE_ARCH)" "playwright-install" }
displayName: Download Electron and Playwright

- ${{ if eq(parameters.VSCODE_RUN_UNIT_TESTS, true) }}:
Expand Down