Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web - allow to specify a full editor layout as embedder #161324

Merged
merged 10 commits into from
Sep 22, 2022
Merged

web - allow to specify a full editor layout as embedder #161324

merged 10 commits into from
Sep 22, 2022

Conversation

bpasero
Copy link
Member

@bpasero bpasero commented Sep 20, 2022

@bpasero bpasero marked this pull request as draft September 20, 2022 15:55
@bpasero bpasero self-assigned this Sep 20, 2022
@bpasero bpasero added this to the September 2022 milestone Sep 20, 2022
@bpasero bpasero marked this pull request as ready for review September 21, 2022 05:17
@bpasero
Copy link
Member Author

bpasero commented Sep 21, 2022

@sandy081 only df072f2 is really relevant, the rest is 💄

sandy081
sandy081 previously approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@sandy081 sandy081 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bpasero bpasero enabled auto-merge (squash) September 22, 2022 08:38
@bpasero bpasero merged commit 436fa9f into main Sep 22, 2022
@bpasero bpasero deleted the ben/impossible-whale branch September 22, 2022 08:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sandy081 sandy081 sandy081 approved these changes

Assignees

@bpasero bpasero

Labels
None yet
Projects
None yet
Milestone
September 2022
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bpasero @sandy081