Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action and menu service improvements #161489

Merged
merged 3 commits into from
Sep 23, 2022
Merged

Action and menu service improvements #161489

merged 3 commits into from
Sep 23, 2022

Commits on Sep 22, 2022

  1. make Separator implement IAction and not extend disposable Action

    @jrieken
    jrieken committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    8c0d8b9 View commit details
    Browse the repository at this point in the history

  2. extract MenuInfo from Menu and let sub menu use the former only, … 

    …no more mutable sub menus but no more create/dispose of them too
    @jrieken
    jrieken committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    b69a74d View commit details
    Browse the repository at this point in the history

  3. Bind the lifecycle of submenus (and listeners) to this.menus becaus… 

    …e that map gets cleared repeatedly

workaround for #161413
    @jrieken
    jrieken committed Sep 22, 2022
    Configuration menu
    Copy the full SHA
    4768357 View commit details
    Browse the repository at this point in the history