Create terminal find widget lazily, add LazyValue helper #161526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi @meganrogge |
jrieken
requested changes
Sep 23, 2022
There was a problem hiding this comment.
Yeah, this already exists as Lazy and we shouldn't duplicate that.
However, I would always use the IdleValue because Lazy is a guarantee for "value is delayed when needed". The point of idle time is to use small remaining time chunks and be ready without blocking
|
@jrieken thanks for the pointer, do you think it's a good idea to derive IdleValue from Lazy like in the PR or keep them separate? |
|
I'd keep them separate |
|
Sounds good, will create a new PR for @meganrogge to review with just the terminal changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrieken a review here would be appreciated as you wrote
IdleValue. The idea here is similar toIdleValuebut it won't initialize the value at all until requested. For this specific use case, I don't want to create find widgets for every terminal as it will often be a waste of cpu/battery/memory. I wouldn't be surprised if something like this already existed, but I couldn't find it if so.