Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .only and fix tests #163376

Merged
merged 2 commits into from Oct 12, 2022
Merged

Remove .only and fix tests #163376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf1ac20
Remove .only and fix tests
mjbvz Oct 11, 2022
35e6549
Merge branch 'main' into isolated-blackbird
mjbvz Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions extensions/markdown-language-features/src/test/documentLink.test.ts
View file
Open in desktop
Expand Up @@ -134,7 +134,7 @@ async function getLinksForFile(file: vscode.Uri): Promise<vscode.DocumentLink[]>
}
});

test('Should navigate to fragment within current untitled file', async () => { // TODO: skip for now for ls migration
test.skip('Should navigate to fragment within current untitled file', async () => { // TODO: skip for now for ls migration
const testFile = workspaceFile('x.md').with({ scheme: 'untitled' });
await withFileContents(testFile, joinLines(
'[](#second)',
Expand Down Expand Up @@ -169,9 +169,8 @@ async function withFileContents(file: vscode.Uri, contents: string): Promise<voi
}

async function executeLink(link: vscode.DocumentLink) {
debugLog('executeingLink', link.target?.toString(), Date.now());
debugLog('executingLink', link.target?.toString(), Date.now());

const args: any[] = JSON.parse(decodeURIComponent(link.target!.query));
await vscode.commands.executeCommand(link.target!.path, vscode.Uri.from(args[0]), ...args.slice(1));
await vscode.commands.executeCommand('vscode.open', link.target!);
debugLog('executedLink', vscode.window.activeTextEditor?.document.toString(), Date.now());
}
2 changes: 1 addition & 1 deletion extensions/markdown-language-features/src/test/engine.test.ts
View file
Open in desktop
Expand Up @@ -30,7 +30,7 @@ suite('markdown.engine', () => {
});
});

suite.only('image-caching', () => {
suite('image-caching', () => {
const input = '![](img.png) [](no-img.png) ![](http://example.org/img.png) ![](img.png) ![](./img2.png)';

test('Extracts all images', async () => {
Expand Down