add restrict search to folder #163597
Merged
add restrict search to folder #163597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
approved these changes
Oct 14, 2022
| }; | ||
|
|
||
| const RESTRICT_SEARCH_TO_FOLDER_ID = 'search.restrictSearchToFolder'; | ||
| KeybindingsRegistry.registerCommandAndKeybindingRule({ |
There was a problem hiding this comment.
Didn't you just convert some actions to Action2? I'd suggest using that for new stuff
There was a problem hiding this comment.
I still need to switch it over; will switch this with the others #162858
| order: 3, | ||
| command: { | ||
| id: RESTRICT_SEARCH_TO_FOLDER_ID, | ||
| title: nls.localize('restrictResultsToFolder', "Restrict Search to Folder...") |
There was a problem hiding this comment.
I'll have to see how I feel about this name, honestly I thought "Find in Folder" is fine - when you have two actions that do exactly the same thing, I would lean towards giving them the same name. But it's fine for now, I don't have a strong opinion.
There was a problem hiding this comment.
Hmm... I think I see it from both perspectives. I'll leave it as is for now and see whether I see differently later on.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In search:
Fixes #161864