馃巵 Add killOnServerStop to debug configuration
#163779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
babakks
changed the title
killOnServerStop to debug configuration
babakks
changed the title
killOnServerStop to debug configurationkillOnServerStop to debug configuration
connor4312
reviewed
Nov 7, 2022
| } | ||
| }); | ||
| this.lateDisposables.push(listener); // In case `trackerId` of interest was never caught anyhow. | ||
| }); |
There was a problem hiding this comment.
Applicable to here and below:
- The listener will be leaked if
startDebuggingreturns false - Even after the listener resolves,
lateDisposableswill keep growing indefinitely.
Maybe lateDisposables should be a Set that you can delete disposables from.
There was a problem hiding this comment.
You're right. Will push a fix soon.
There was a problem hiding this comment.
Made the changes as you suggested. the lateDisposables is a Set now. Also used vscode.CancellationToken for signaling whether to stop listening for events anymore.
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
connor4312
previously approved these changes
Nov 14, 2022
roblourens
reviewed
Nov 16, 2022
| return vscode.debug.startDebugging(session.workspaceFolder, { | ||
| type, | ||
| name: 'Browser Debug', | ||
| request: 'launch', | ||
| url: uri, | ||
| webRoot: session.configuration.serverReadyAction.webRoot || WEB_ROOT | ||
| webRoot: session.configuration.serverReadyAction.webRoot || WEB_ROOT, | ||
| trackerId, |
There was a problem hiding this comment.
Please use a more unique name for this. Since it's being added to another extension's launch config, I think it should reflect where it came from and the fact that it's sort of internal, I suggest _debugServerReadySessionId.
Actually it's interesting that startDebugging doesn't return a DebugSession, I sort of expected it would. That would make this easier.
There was a problem hiding this comment.
It would indeed. But getting an API change in for that would be awkward, we'd need to duplicate the method 馃槙
|
There's also a merge conflict here |
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Merged with the |
roblourens
approved these changes
Nov 17, 2022
lramos15
pushed a commit
that referenced
this pull request
Nov 17, 2022
* 馃巵 Add `killOnServerStop` to schema Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃摐 Add description for `killOnServerStop` Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃敤 Stop created debug session on server stop Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃敤 Push kill listeners into another disposable container Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃悰 Prevent leak when new debug session fails to start Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃敤 Use more verbose name for debug session tracker ID Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
lramos15
added a commit
that referenced
this pull request
Nov 17, 2022
* Remove i18n causing classifier to fail due to missing label * 馃巵 Add `killOnServerStop` to debug configuration (#163779) * 馃巵 Add `killOnServerStop` to schema Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃摐 Add description for `killOnServerStop` Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃敤 Stop created debug session on server stop Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃敤 Push kill listeners into another disposable container Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃悰 Prevent leak when new debug session fails to start Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * 馃敤 Use more verbose name for debug session tracker ID Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> * assign bhayva to getting started Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com> Co-authored-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163124
A new configuration parameter, named
killOnServerStop, is added. When this parameter is enabled, child debug sessions will be stopped whenever the server (the parent session) stops. The default value for the parameter isfalseto keep the existing behavior unchanged.Verification
To verify this PR, use babakks/vscode-verify-kill-on-server-stop which is made for this purpose. Instructions are available in the
README.mdof the repo.