Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose of rendered markdown properly #163944

Merged
merged 1 commit into from Oct 18, 2022
Merged

Dispose of rendered markdown properly #163944

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/vs/workbench/contrib/scm/browser/scmViewPane.ts
View file
Open in desktop
Expand Up @@ -2132,7 +2132,8 @@ class SCMInputWidget {
this.contextViewService.hideContextView();
}));

const { element: mdElement } = this.instantiationService.createInstance(MarkdownRenderer, {}).render(message, {
const renderer = disposables.add(this.instantiationService.createInstance(MarkdownRenderer, {}));
const renderedMarkdown = renderer.render(message, {
actionHandler: {
callback: (content) => {
this.openerService.open(content, { allowCommands: typeof message !== 'string' && message.isTrusted });
Expand All @@ -2141,7 +2142,8 @@ class SCMInputWidget {
disposables: disposables
},
});
element.appendChild(mdElement);
disposables.add(renderedMarkdown);
element.appendChild(renderedMarkdown.element);
}
const actionsContainer = append(validationContainer, $('.scm-editor-validation-actions'));
const actionbar = new ActionBar(actionsContainer);
Expand Down