Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove notification on successful kill of process in freeing port #163951

Merged
merged 1 commit into from Oct 18, 2022
Merged

remove notification on successful kill of process in freeing port #163951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts
View file
Open in desktop
Expand Up @@ -177,8 +177,7 @@ export class TerminalProcessManager extends Disposable implements ITerminalProce
async freePortKillProcess(port: string): Promise<void> {
try {
if (this._process?.freePortKillProcess) {
const result = await this._process?.freePortKillProcess(port);
this._notificationService.notify({ message: localize('killportsuccess', 'Killed process with PID {0} listening on port {1}', result.processId, result.port), severity: Severity.Info });
await this._process?.freePortKillProcess(port);
}
} catch (e) {
this._notificationService.notify({ message: localize('killportfailure', 'Could not kill process listening on port {0}, command exited with error {1}', port, e), severity: Severity.Warning });
Expand Down