Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debt - remove _isFakeAction again #164240

Merged
merged 1 commit into from Oct 21, 2022
Merged

debt - remove _isFakeAction again #164240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/vs/platform/action/common/action.ts
View file
Open in desktop
Expand Up @@ -72,9 +72,6 @@ export interface ICommandAction {
* or define toggle-info including an icon and a title that goes well with a checkmark.
*/
toggled?: ContextKeyExpression | ICommandActionToggleInfo;

/** @deprecated see https://github.com/microsoft/vscode/issues/162004 */
_isFakeAction?: true;
}

export type ISerializableCommandAction = UriDto<ICommandAction>;
7 changes: 0 additions & 7 deletions src/vs/platform/actions/common/actions.ts
View file
Open in desktop
Expand Up @@ -556,13 +556,6 @@ interface IAction2CommonOptions extends ICommandAction {
* showing keybindings that have no other UX.
*/
description?: ICommandHandlerDescription;

/**
* @deprecated workaround added for https://github.com/microsoft/vscode/issues/162004
* This action doesn't do anything is just a workaround for rendering "something"
* inside a specific toolbar
*/
_isFakeAction?: true;
}

interface IBaseAction2Options extends IAction2CommonOptions {
Expand Down
3 changes: 1 addition & 2 deletions src/vs/platform/actions/common/menuService.ts
View file
Open in desktop
Expand Up @@ -228,8 +228,7 @@ class MenuInfo {
const menuHide = createMenuHide(this._id, isMenuItem ? item.command : item, this._hiddenStates);
if (isMenuItem) {
// MenuItemAction
const actualMenuHide = item.command._isFakeAction ? undefined : menuHide;
activeActions.push(new MenuItemAction(item.command, item.alt, options, actualMenuHide, this._contextKeyService, this._commandService));
activeActions.push(new MenuItemAction(item.command, item.alt, options, menuHide, this._contextKeyService, this._commandService));

} else {
// SubmenuItemAction
Expand Down