Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick up latest markdown language service and clean up server package #164516

Merged
merged 1 commit into from Oct 24, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion extensions/markdown-language-features/server/README.md
Expand Up @@ -34,7 +34,7 @@ This server uses the [Markdown Language Service](https://github.com/microsoft/vs
- Organize link definitions source action.
- Extract link to definition refactoring.

- (experimental) Updating links when a file is moved / renamed. Uses a custom `markdown/getEditForFileRenames` message.
- Updating links when a file is moved / renamed. Uses a custom `markdown/getEditForFileRenames` message.

- [Pull diagnostics (validation)](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics) for links.

Expand All @@ -56,6 +56,10 @@ The server supports the following settings:
- `suggest`
- `paths`
- `enabled` — Enable/disable path suggestions.

- `occurrencesHighlight`
- `enabled` — Enable/disable highlighting of link occurrences.

- `validate`
- `enabled` — Enable/disable all validation.
- `referenceLinks`
Expand Down
9 changes: 7 additions & 2 deletions extensions/markdown-language-features/server/package.json
@@ -1,19 +1,23 @@
{
"name": "vscode-markdown-languageserver",
"description": "Markdown language server",
"version": "0.0.0-alpha-5",
"version": "0.2.0-alpha.4",
"author": "Microsoft Corporation",
"license": "MIT",
"engines": {
"node": "*"
},
"main": "./out/node/main",
"browser": "./dist/browser/main",
"files": [
"dist/**/*.js",
"out/**/*.js"
],
"dependencies": {
"vscode-languageserver": "^8.0.2",
"vscode-languageserver-textdocument": "^1.0.5",
"vscode-languageserver-types": "^3.17.1",
"vscode-markdown-languageservice": "^0.2.0-alpha.3",
"vscode-markdown-languageservice": "^0.2.0-alpha.4",
"vscode-nls": "^5.2.0",
"vscode-uri": "^3.0.3"
},
Expand All @@ -22,6 +26,7 @@
},
"scripts": {
"compile": "gulp compile-extension:markdown-language-features-server",
"prepublishOnly": "npm run compile",
"watch": "gulp watch-extension:markdown-language-features-server"
}
}
135 changes: 135 additions & 0 deletions extensions/markdown-language-features/server/package/README.md
@@ -0,0 +1,135 @@
# Markdown Language Server

> **❗ Import** This is still in development. While the language server is being used by VS Code, it has not yet been tested with other clients.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Important instead of import


The Markdown language server powers VS Code's built-in markdown support, providing tools for writing and browsing Markdown files. It runs as a separate executable and implements the [language server protocol](https://microsoft.github.io/language-server-protocol/overview).

This server uses the [Markdown Language Service](https://github.com/microsoft/vscode-markdown-languageservice) to implement almost all of the language features. You can use that library if you need a library for working with Markdown instead of a full language server.


## Server capabilities

- [Completions](https://microsoft.github.io/language-server-protocol/specification#textDocument_completion) for Markdown links.

- [Folding](https://microsoft.github.io/language-server-protocol/specification#textDocument_foldingRange) of Markdown regions, block elements, and header sections.

- [Smart selection](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_selectionRange) for inline elements, block elements, and header sections.

- [Document Symbols](https://microsoft.github.io/language-server-protocol/specification#textDocument_documentSymbol) for quick navigation to headers in a document.
Copy link
Contributor

@rzhao271 rzhao271 Oct 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: casing on this link text is inconsistent with other links


- [Workspace Symbols](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_symbol) for quick navigation to headers in the workspace

- [Document links](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_documentLink) for making Markdown links in a document clickable.

- [Find all references](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_references) to headers and links across all Markdown files in the workspace.

- [Go to definition](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_definition) from links to headers or link definitions.

- [Rename](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_rename) of headers and links across all Markdown files in the workspace.

- Find all references to a file. Uses a custom `markdown/getReferencesToFileInWorkspace` message.

- [Code Actions](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_codeAction)

- Organize link definitions source action.
- Extract link to definition refactoring.

- Updating links when a file is moved / renamed. Uses a custom `markdown/getEditForFileRenames` message.

- [Pull diagnostics (validation)](https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_pullDiagnostics) for links.


## Client requirements

### Initialization options

The client can send the following initialization options to the server:

- `markdownFileExtensions` Array file extensions that should be considered as Markdown. These should not include the leading `.`. For example: `['md', 'mdown', 'markdown']`.

### Settings

Clients may send a `workspace/didChangeConfiguration` notification to notify the server of settings changes.
The server supports the following settings:

- `markdown`
- `suggest`
- `paths`
- `enabled` — Enable/disable path suggestions.

- `occurrencesHighlight`
- `enabled` — Enable/disable highlighting of link occurrences.

- `validate`
- `enabled` — Enable/disable all validation.
- `referenceLinks`
- `enabled` — Enable/disable validation of reference links: `[text][ref]`
- `fragmentLinks`
- `enabled` — Enable/disable validation of links to fragments in the current files: `[text](#head)`
- `fileLinks`
- `enabled` — Enable/disable validation of links to file in the workspace.
- `markdownFragmentLinks` — Enable/disable validation of links to headers in other Markdown files. Use `inherit` to inherit the `fragmentLinks` setting.
- `ignoredLinks` — Array of glob patterns for files that should not be validated.
- `unusedLinkDefinitions`
- `enabled` — Enable/disable validation of unused link definitions.
- `duplicateLinkDefinitions`
- `enabled` — Enable/disable validation of duplicated link definitions.

### Custom requests

To support all of the features of the language server, the client needs to implement a few custom request types. The definitions of these request types can be found in [`protocol.ts`](./src/protocol.ts)

#### `markdown/parse`

Get the tokens for a Markdown file. Clients are expected to use [Markdown-it](https://github.com/markdown-it/markdown-it) for this.

We require that clients bring their own version of Markdown-it so that they can customize/extend Markdown-it.

#### `markdown/fs/readFile`

Read the contents of a file in the workspace.

#### `markdown/fs/readDirectory`

Read the contents of a directory in the workspace.

#### `markdown/fs/stat`

Check if a given file/directory exists in the workspace.

#### `markdown/fs/watcher/create`

Create a file watcher. This is needed for diagnostics support.

#### `markdown/fs/watcher/delete`

Delete a previously created file watcher.

#### `markdown/findMarkdownFilesInWorkspace`

Get a list of all markdown files in the workspace.


## Contribute

The source code of the Markdown language server can be found in the [VSCode repository](https://github.com/microsoft/vscode) at [extensions/markdown-language-features/server](https://github.com/microsoft/vscode/tree/master/extensions/markdown-language-features/server).

File issues and pull requests in the [VSCode GitHub Issues](https://github.com/microsoft/vscode/issues). See the document [How to Contribute](https://github.com/microsoft/vscode/wiki/How-to-Contribute) on how to build and run from source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "VSCode GitHub issues tracker" or remove "the" in front of the link text


Most of the functionality of the server is located in libraries:

- [vscode-markdown-languageservice](https://github.com/microsoft/vscode-markdown-languageservice) contains the implementation of all features as a reusable library.
- [vscode-languageserver-node](https://github.com/microsoft/vscode-languageserver-node) contains the implementation of language server for NodeJS.

Help on any of these projects is very welcome.

## Code of Conduct

This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.

## License

Copyright (c) Microsoft Corporation. All rights reserved.

Licensed under the [MIT](https://github.com/microsoft/vscode/blob/master/LICENSE.txt) License.

32 changes: 32 additions & 0 deletions extensions/markdown-language-features/server/package/package.json
@@ -0,0 +1,32 @@
{
"name": "vscode-markdown-languageserver",
"description": "Markdown language server",
"version": "0.2.0-alpha.4",
"author": "Microsoft Corporation",
"license": "MIT",
"engines": {
"node": "*"
},
"main": "./out/node/main",
"browser": "./dist/browser/main",
"files": [
"dist/**/*.js",
"out/**/*.js"
],
"dependencies": {
"vscode-languageserver": "^8.0.2",
"vscode-languageserver-textdocument": "^1.0.5",
"vscode-languageserver-types": "^3.17.1",
"vscode-markdown-languageservice": "^0.2.0-alpha.4",
"vscode-nls": "^5.2.0",
"vscode-uri": "^3.0.3"
},
"devDependencies": {
"@types/node": "16.x"
},
"scripts": {
"compile": "gulp compile-extension:markdown-language-features-server",
"prepublishOnly": "npm run compile",
"watch": "gulp watch-extension:markdown-language-features-server"
}
}
11 changes: 0 additions & 11 deletions extensions/markdown-language-features/server/src/util/arrays.ts

This file was deleted.

8 changes: 4 additions & 4 deletions extensions/markdown-language-features/server/yarn.lock
Expand Up @@ -42,10 +42,10 @@ vscode-languageserver@^8.0.2:
dependencies:
vscode-languageserver-protocol "3.17.2"

vscode-markdown-languageservice@^0.2.0-alpha.3:
version "0.2.0-alpha.3"
resolved "https://registry.yarnpkg.com/vscode-markdown-languageservice/-/vscode-markdown-languageservice-0.2.0-alpha.3.tgz#5bc3934ebb97ce855f49fbb345a5e1f5ace7d660"
integrity sha512-3ikmh1Mcr9s5s0wZZsxb7heSzKooudCgtZzL5d8t94WDbg02u9i2cDYF6qufK6Og5pBSC3ajeF12qFAYbRIbgQ==
vscode-markdown-languageservice@^0.2.0-alpha.4:
version "0.2.0-alpha.4"
resolved "https://registry.yarnpkg.com/vscode-markdown-languageservice/-/vscode-markdown-languageservice-0.2.0-alpha.4.tgz#51856ffa9750782bf952fe97765fb29c3ec27c06"
integrity sha512-a08s+AEwPTYqilMW8ZF3FAeDf+5pUo+XOgynPHvc70ABFTTr9fNVlg99quFUQINvi/eihH8+cd3/j/Qijeauew==
dependencies:
picomatch "^2.3.1"
vscode-languageserver-textdocument "^1.0.5"
Expand Down