Highlight label should not create extra span nodes #164657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor
|
Looks good to me, but @jrieken probably knows more why the span was added initially |
jrieken
requested changes
Oct 31, 2022
There was a problem hiding this comment.
This needs the same change as the smoke test (or should be removed):
vscode/src/vs/base/parts/quickinput/browser/media/quickInput.css
Lines 240 to 242 in eca16a8
samyarkd
approved these changes
Oct 31, 2022
samyarkd
approved these changes
Oct 31, 2022
samyarkd
previously approved these changes
Oct 31, 2022
jrieken
approved these changes
Nov 1, 2022
lemanschik
pushed a commit
to code-oss-dev/code
that referenced
this pull request
Nov 25, 2022
* Highlight label should not create extra empty dom nodes I noticed that the `HighlightedLabel` class creates extra `span` elements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the document I also related the conditional spread with a longer version that uses a simple call to push. This is worth doing since `HighlightedLabel` is so widely used in the editor * Update tests * Update smoke test selector * Update css
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
HighlightedLabelclass creates extraspanelements for text ranges. These should not be needed. Using text children directly should be faster for creation and also reduce the number of nodes in the documentI also replaced the conditional spread with a longer version that uses a simple call to push. This is worth doing since
HighlightedLabelis so widely used in the editor