Swap list/tree icons to reflect current state instead of target state

[daviddossett]

Ref #162595

Swaps flat list and tree list icons in the Search and SCM views to represent what you're currently looking at instead of what you can toggle to.

CleanShot.2022-10-27.at.16.47.16.mp4

cc @andreamah @lszomoru

[roblourens]

I prefer the other way but ok :(

[roblourens]

I looked at the examples in the thread and I definitely agree with you on the other cases, like "pinned" should the current state, so I don't know why I'm inconsistent.

[andreamah]

It is a little tricky, since stuff like the collapse button still shows target state. Could it be that it's inline with other icons that show target state that throws you off? @roblourens

[daviddossett]

the collapse button still shows target state.

That's a good point. For whatever reason that feels more like a command rather than a UI state. That is to say, it might be strange to show the UI saying "you're currently looking at a collapsed list". Maybe because it's less of a formal view state and more of a cleanup utility of sorts?

[andreamah]

True. Have we considered using something like the case-sensitive highlight in find widgets?

So rather than toggling the icon, we're essentially either in "tree mode on" or "tree mode off"

[daviddossett]

I was thinking about that too. I'm wondering if we use those boolean toggles outside of text inputs anywhere. I can't think of any off the top of my head.

[andreamah]

Yeah, I think I looked into this when I created #162088. It didn't seem like there was anywhere I could find, but I think it's a clear way to show a toggle and we should maybe have it in more places (?)

[daviddossett]

My only concern is that they seem better suited for something that is on or off rather than two descriptive non-boolean states. Based on the feedback in the UX channel I'll merge this as a starting point and we can see how it feels. Happy to continue iterating on this if we sit with it for a while and it doesn't feel right.