Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build task cacophony / debounce audio cues #164921

Closed
meganrogge opened this issue Oct 28, 2022 · 7 comments
Closed

build task cacophony / debounce audio cues #164921

meganrogge opened this issue Oct 28, 2022 · 7 comments
Assignees
@hediet @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Milestone
November 2022

Comments

@meganrogge
Copy link
Contributor

When running a build task (like VS Code's build task) w the new fail/success audio cues, it sounds like the failure noise starts to play and then the success one is overlaid. We should make sure to manage this better
@meganrogge meganrogge self-assigned this Oct 28, 2022
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels Oct 28, 2022
@meganrogge meganrogge added this to the November 2022 milestone Oct 28, 2022
@meganrogge meganrogge added the accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues label Oct 28, 2022
@meganrogge
Copy link
Contributor Author

related #163731

@meganrogge
Copy link
Contributor Author

Screen Shot 2022-10-31 at 1 34 23 PM

the audio cue is always enabled here

vscode/src/vs/workbench/contrib/audioCues/browser/audioCueService.ts

Lines 41 to 48 in 287d963

public async playAudioCue(cue: AudioCue): Promise<void> {
if (this.isEnabled(cue).get()) {
await this.playSound(cue.sound);
}
}
public async playAudioCues(cues: AudioCue[]): Promise<void> {

@meganrogge
Copy link
Contributor Author

@hediet are consumers of this expected to handle repeat requests?

@hediet
Copy link
Member

hediet commented Oct 31, 2022

Currently, the audio cue service does not do any debouncing.

What do you suggest?

@meganrogge
Copy link
Contributor Author

I would suggest the audio cue service drops any requests to play a sound that's already playing

@hediet
Copy link
Member

hediet commented Oct 31, 2022

Sounds reasonable.

@hediet hediet changed the title build task cacophony build task cacophony / debounce audio cues Oct 31, 2022
@hediet hediet self-assigned this Oct 31, 2022
@meganrogge
Copy link
Contributor Author

I'd suggest the same thing for playSound which would fix #163731

hediet added a commit that referenced this issue Nov 1, 2022
@hediet
Audio Cues: Don't play the same sound in parallel. Fixes #164921
c987332
@hediet hediet closed this as completed in d810d86 Nov 1, 2022
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 1, 2022
@meganrogge meganrogge mentioned this issue Nov 4, 2022
Merged
@connor4312 connor4312 added the verified Verification succeeded label Nov 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tasks Task system issues verified Verification succeeded
Projects
None yet
Milestone
November 2022
Development

No branches or pull requests
4 participants
@connor4312 @hediet @meganrogge @VSCodeTriageBot