-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build task cacophony / debounce audio cues #164921
Comments
related #163731 |
the audio cue is always enabled here vscode/src/vs/workbench/contrib/audioCues/browser/audioCueService.ts Lines 41 to 48 in 287d963
|
@hediet are consumers of this expected to handle repeat requests? |
Currently, the audio cue service does not do any debouncing. What do you suggest? |
I would suggest the audio cue service drops any requests to play a sound that's already playing |
Sounds reasonable. |
I'd suggest the same thing for |
When running a build task (like VS Code's build task) w the new fail/success audio cues, it sounds like the failure noise starts to play and then the success one is overlaid. We should make sure to manage this better
The text was updated successfully, but these errors were encountered: