Fix bugs with close of markdown docs #164942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two bugs here: - Something in the lsp is converting a value from `undefined` to `null`. To fix this, I've updated us just to check for falsy values instead - The `hasInMemoryDoc` implementation was incorrect. It needs to verify that the value of `this.inMemoryDoc` is not null/undefined
mjbvz
commented
Oct 28, 2022
joyceerhl
approved these changes
Oct 28, 2022
mjbvz
added a commit
to mjbvz/vscode
that referenced
this pull request
Oct 29, 2022
This is a cherry pick of two fixes: - microsoft#164945 which fixes microsoft#164932 by picking up a new md language service version - microsoft#164942 which fixes microsoft#164562 by fixing a bug with the md workspace implementation
mjbvz
added a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #164562
There are two bugs here:
Something in the lsp is converting a value from
undefinedtonull. To fix this, I've updated us just to check for falsy values insteadThe
hasInMemoryDocimplementation was incorrect. It needs to verify that the value ofthis.inMemoryDocis not null/undefined