Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt notebook serializer for notebook document tests #165081

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Adopt notebook serializer for notebook document tests #165081

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1910fc0
Adopt notebook serializer for notebook document tests
mjbvz Oct 31, 2022
dd8cabb
Merge branch 'main' into classical-scallop
mjbvz Oct 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 4 additions & 22 deletions extensions/vscode-api-tests/src/singlefolder-tests/notebook.document.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@ suite('Notebook Document', function () {
}
};

const complexContentProvider = new class implements vscode.NotebookContentProvider {
async openNotebook(uri: vscode.Uri, _openContext: vscode.NotebookDocumentOpenContext): Promise<vscode.NotebookData> {
return new vscode.NotebookData(
[new vscode.NotebookCellData(vscode.NotebookCellKind.Code, uri.toString(), 'javascript')],
);
}
};

const disposables: vscode.Disposable[] = [];
const testDisposables: vscode.Disposable[] = [];

Expand All @@ -45,17 +37,7 @@ suite('Notebook Document', function () {
});

suiteSetup(function () {
disposables.push(vscode.workspace.registerNotebookContentProvider('notebook.nbdtest', complexContentProvider));
disposables.push(vscode.workspace.registerNotebookSerializer('notebook.nbdserializer', simpleContentProvider));
});

test('cannot register sample provider multiple times', function () {
assert.throws(() => {
vscode.workspace.registerNotebookContentProvider('notebook.nbdtest', complexContentProvider);
});
// assert.throws(() => {
// vscode.workspace.registerNotebookSerializer('notebook.nbdserializer', simpleContentProvider);
// });
disposables.push(vscode.workspace.registerNotebookSerializer('notebook.nbdtest', simpleContentProvider));
});

test('cannot open unknown types', async function () {
Expand Down Expand Up @@ -131,7 +113,7 @@ suite('Notebook Document', function () {
});

test('open untitled notebook', async function () {
const nb = await vscode.workspace.openNotebookDocument('notebook.nbdserializer');
const nb = await vscode.workspace.openNotebookDocument('notebook.nbdtest');
assert.strictEqual(nb.isUntitled, true);
assert.strictEqual(nb.isClosed, false);
assert.strictEqual(nb.uri.scheme, 'untitled');
Expand All @@ -140,7 +122,7 @@ suite('Notebook Document', function () {

test('open untitled with data', async function () {
const nb = await vscode.workspace.openNotebookDocument(
'notebook.nbdserializer',
'notebook.nbdtest',
new vscode.NotebookData([
new vscode.NotebookCellData(vscode.NotebookCellKind.Code, 'console.log()', 'javascript'),
new vscode.NotebookCellData(vscode.NotebookCellKind.Markup, 'Hey', 'markdown'),
Expand Down Expand Up @@ -353,7 +335,7 @@ suite('Notebook Document', function () {
});

test('dirty state - serializer', async function () {
const resource = await utils.createRandomFile(undefined, undefined, '.nbdserializer');
const resource = await utils.createRandomFile(undefined, undefined, '.nbdtest');
const document = await vscode.workspace.openNotebookDocument(resource);
assert.strictEqual(document.isDirty, false);

Expand Down