Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Enterprise Auth improvements #165082

Merged
merged 1 commit into from
Oct 31, 2022
Merged

GitHub Enterprise Auth improvements #165082

merged 1 commit into from
Oct 31, 2022

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Oct 31, 2022 •
edited
Loading

  1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
  2. If the setting value disappears, continue using last set value. Fixes Enterprise: Not Found error when opening PR description vscode-pull-request-github#3992
  3. Mark github-enterprise.uri as requires trust
  4. Refactoring like:
  • UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
  • misc style (private usage, better disposable handling)

@TylerLeonhardt
GitHub Enterprise Auth improvements
4c50cf6 
1. Namespace secrets based on the value of github-enterprise.uri to support "multiple separate GHES instances"
2. If the setting value disappears, continue using last set value. Fixes microsoft/vscode-pull-request-github#3992
3. Mark github-enterprise.uri as requires trust
3. Refactoring like:
  * UriHandler is handled in extension.ts and passed down everywhere since we can only have 1 instance of it
  * misc style (`private` usage, better `disposable` handling)
@TylerLeonhardt TylerLeonhardt enabled auto-merge (squash) October 31, 2022 18:58
@TylerLeonhardt TylerLeonhardt self-assigned this Oct 31, 2022
@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Oct 31, 2022
@TylerLeonhardt TylerLeonhardt merged commit 9b3e147 into main Oct 31, 2022
@TylerLeonhardt TylerLeonhardt deleted the tyler/crooked-stingray branch October 31, 2022 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lramos15 lramos15 lramos15 approved these changes

Assignees

@TylerLeonhardt TylerLeonhardt

Labels
None yet
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

Enterprise: Not Found error when opening PR description
3 participants
@TylerLeonhardt @lramos15 @VSCodeTriageBot