Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump version for Nov. (#165091)" #165118

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

mjbvz
Copy link
Collaborator

@mjbvz mjbvz commented Nov 1, 2022

@mjbvz mjbvz added this to the November 2022 milestone Nov 1, 2022
@mjbvz mjbvz self-assigned this Nov 1, 2022
@mjbvz mjbvz enabled auto-merge (squash) November 1, 2022 03:26
@joaomoreno
Copy link
Member

joaomoreno commented Nov 1, 2022

@rebornix @mjbvz This is a bug. We should always be able to bump the version and the smoke tests should not fail. I at least expected an issue to have been created out of this incident instead of accidentally finding out about this in our DevOps builds page.

Here's the proper fix: #165132

@lorand-horvath
Copy link

lorand-horvath commented Nov 1, 2022

@joaomoreno Thanks for fixing this. So can package.json be finally bumped to 1.74.0 now? Revert the revert? :-)

@joaomoreno
Copy link
Member

Already done: #165133

lemanschik pushed a commit to code-oss-dev/code that referenced this pull request Nov 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants