Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup class exports #165413

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Cleanup class exports #165413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 0 additions & 21 deletions src/vs/platform/assignment/common/assignmentService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,6 @@ import { IProductService } from 'vs/platform/product/common/productService';
import { getTelemetryLevel } from 'vs/platform/telemetry/common/telemetryUtils';
import { AssignmentFilterProvider, ASSIGNMENT_REFETCH_INTERVAL, ASSIGNMENT_STORAGE_KEY, IAssignmentService, TargetPopulation } from 'vs/platform/assignment/common/assignment';

class NullAssignmentServiceTelemetry implements IExperimentationTelemetry {
constructor() { }

setSharedProperty(name: string, value: string): void {
// noop due to lack of telemetry service
}

postEvent(eventName: string, props: Map<string, string>): void {
// noop due to lack of telemetry service
}
}

export abstract class BaseAssignmentService implements IAssignmentService {
_serviceBrand: undefined;
protected tasClient: Promise<TASClient> | undefined;
Expand Down Expand Up @@ -112,12 +100,3 @@ export abstract class BaseAssignmentService implements IAssignmentService {
return tasClient;
}
}

export class AssignmentService extends BaseAssignmentService {
constructor(
machineId: string,
configurationService: IConfigurationService,
productService: IProductService) {
super(() => Promise.resolve(machineId), configurationService, productService, new NullAssignmentServiceTelemetry());
}
}
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/files/browser/fileActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ export class ToggleAutoSaveAction extends Action2 {
}
}

export abstract class BaseSaveAllAction extends Action {
abstract class BaseSaveAllAction extends Action {
private lastDirtyState: boolean;

constructor(
Expand Down