Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update role and aria-label for the Hide button in the Welcome View #165505

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Update role and aria-label for the Hide button in the Welcome View #165505

merged 1 commit into from
Nov 4, 2022

Conversation

bhavyaus
Copy link
Contributor

@bhavyaus bhavyaus commented Nov 4, 2022

Fixes #160409
image

Also fixes #160396

@VSCodeTriageBot VSCodeTriageBot added this to the November 2022 milestone Nov 4, 2022
lramos15
lramos15 approved these changes Nov 4, 2022
View reviewed changes
Copy link
Member

@lramos15 lramos15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@bhavyaus bhavyaus added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues getting-started labels Nov 4, 2022
@bhavyaus bhavyaus merged commit 4a5d501 into main Nov 4, 2022
@bhavyaus bhavyaus deleted the dev/bhavyau/accessibility-close-button branch November 4, 2022 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

@lramos15 lramos15 lramos15 approved these changes

Assignees

@bhavyaus bhavyaus

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues getting-started
Projects
None yet
Milestone
November 2022
Development

Successfully merging this pull request may close these issues.

Welcome View - buttons should have button role set Welcome View - buttons should have aria-label set
4 participants
@bhavyaus @TylerLeonhardt @lramos15 @VSCodeTriageBot