Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#165169 Move css rules from editorScrollbar.ts into editorScrollbar.css #165511

Closed
wants to merge 3 commits into from
Closed

#165169 Move css rules from editorScrollbar.ts into editorScrollbar.css #165511

wants to merge 3 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 4, 2022

#165169

Deleted registerThemingParticipant, relevant imports from editorScrollbar.ts, and moved the css rules to editorScrollbar.css

Test by running code and the scroll bar colours are correct, also run scripts/test.sh, no failed tests

-Andrew John Roy Stephenson andrewjohnroy@gmail.com

colour-of-art and others added 2 commits November 5, 2022 01:49
…165169

Deleted registerThemingParticipant, relevant imports, and moved the css rules to editorScrollbar.css

-Andrew John Roy Stephenson andrewjohnroy@gmail.com
@ghost
Copy link
Author

ghost commented Nov 4, 2022

@microsoft-github-policy-service agree

@rzhao271
Copy link
Contributor

rzhao271 commented Nov 4, 2022

Hi Andrew,
Unfortunately, #165464 implements scrollbar refactoring already.
The entry in src/vs/workbench/contrib/feedback/ might be safe to work on.

@ghost ghost closed this by deleting the head repository Nov 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants