Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More telemetry cleanup #165952

Merged
merged 1 commit into from Nov 9, 2022
Merged

More telemetry cleanup #165952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/api/common/extHostTelemetry.ts
View file
Open in desktop
Expand Up @@ -145,13 +145,13 @@ export class ExtHostTelemetryLogger {
// TODO @lramos15 should this be up to the implementer and not done here?
let updatedData = data.properties ?? data;

// We don't clean measurements since they are just numbers
updatedData = cleanData(updatedData, []);

if (this._appender.additionalCommonProperties) {
updatedData = mixin(updatedData, this._appender.additionalCommonProperties);
}

// We don't clean measurements since they are just numbers
updatedData = cleanData(updatedData, []);

if (!this._appender.ignoreBuiltInCommonProperties) {
updatedData = mixin(updatedData, this._commonProperties);
}
Expand Down
3 changes: 0 additions & 3 deletions src/vs/workbench/contrib/telemetry/browser/telemetry.contribution.ts
View file
Open in desktop
Expand Up @@ -77,7 +77,6 @@ export class TelemetryContribution extends Disposable implements IWorkbenchContr

type WorkspaceLoadClassification = {
owner: 'bpasero';
userAgent: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; comment: 'The user agent as reported by `navigator.userAgent` by Electron or the web browser.' };
emptyWorkbench: { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Whether a folder or workspace is opened or not.' };
windowSize: WindowSizeFragment;
'workbench.filesToOpenOrCreate': { classification: 'SystemMetaData'; purpose: 'FeatureInsight'; isMeasurement: true; comment: 'Number of files that should open or be created.' };
Expand All @@ -94,7 +93,6 @@ export class TelemetryContribution extends Disposable implements IWorkbenchContr
};

type WorkspaceLoadEvent = {
userAgent: string;
windowSize: { innerHeight: number; innerWidth: number; outerHeight: number; outerWidth: number };
emptyWorkbench: boolean;
'workbench.filesToOpenOrCreate': number;
Expand All @@ -110,7 +108,6 @@ export class TelemetryContribution extends Disposable implements IWorkbenchContr
};

telemetryService.publicLog2<WorkspaceLoadEvent, WorkspaceLoadClassification>('workspaceLoad', {
userAgent: navigator.userAgent,
windowSize: { innerHeight: window.innerHeight, innerWidth: window.innerWidth, outerHeight: window.outerHeight, outerWidth: window.outerWidth },
emptyWorkbench: contextService.getWorkbenchState() === WorkbenchState.EMPTY,
'workbench.filesToOpenOrCreate': filesToOpenOrCreate && filesToOpenOrCreate.length || 0,
Expand Down