Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store manifest as is #166260

Merged
merged 1 commit into from Nov 14, 2022
Merged

store manifest as is #166260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/vs/workbench/services/extensionManagement/browser/webExtensionsScannerService.ts
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@ interface IStoredWebExtension {
readonly identifier: IExtensionIdentifier;
readonly version: string;
readonly location: UriComponents;
readonly manifest?: string;
readonly manifest?: IExtensionManifest;
readonly readmeUri?: UriComponents;
readonly changelogUri?: UriComponents;
// deprecated in favor of packageNLSUris & fallbackPackageNLSUri
Expand Down Expand Up @@ -806,7 +806,7 @@ export class WebExtensionsScannerService extends Disposable implements IWebExten
identifier: e.identifier,
version: e.version,
location: URI.revive(e.location),
manifest: e.manifest ? JSON.parse(e.manifest) : undefined,
manifest: e.manifest,
readmeUri: URI.revive(e.readmeUri),
changelogUri: URI.revive(e.changelogUri),
packageNLSUris,
Expand Down Expand Up @@ -869,7 +869,7 @@ export class WebExtensionsScannerService extends Disposable implements IWebExten
const storedWebExtensions: IStoredWebExtension[] = webExtensions.map(e => ({
identifier: e.identifier,
version: e.version,
manifest: e.manifest ? JSON.stringify(e.manifest) : undefined,
manifest: e.manifest,
location: e.location.toJSON(),
readmeUri: e.readmeUri?.toJSON(),
changelogUri: e.changelogUri?.toJSON(),
Expand Down