Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Copy webServer from Typescript to VS Code" #166364

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

hediet
Copy link
Member

@hediet hediet commented Nov 15, 2022

Reverts #165771

This breaks the web build:

[14:05:45] Using gulpfile C:\dev\microsoft\vscode\gulpfile.js
[14:05:45] Starting 'vscode-web-min-ci'...
[14:05:45] Starting clean-web-extensions-build ...
[14:05:45] Finished clean-web-extensions-build after 2 ms
[14:05:45] Starting bundle-web-extensions-build ...
C:\dev\microsoft\vscode\extensions\typescript-language-features
[]
[14:06:02] 'vscode-web-min-ci' errored after 17 s
[14:06:02] TypeError: Cannot read properties of undefined (reading 'path')
    at C:\dev\microsoft\vscode\build\lib\extensions.js:125:90
    at Array.map (<anonymous>)
    at C:\dev\microsoft\vscode\build\lib\extensions.js:107:55

Seems like this file returns an array, but some other scripts expects it not to:

@hediet hediet merged commit 41cdd51 into main Nov 15, 2022
@hediet hediet deleted the revert-165771-tsserver-webhost branch November 15, 2022 16:09
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants