Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Modified elsewhere tabIndex bug #166918

Merged
merged 1 commit into from Nov 22, 2022
Merged

Fix Modified elsewhere tabIndex bug #166918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/preferences/browser/settingsEditorSettingIndicators.ts
View file
Open in desktop
Expand Up @@ -140,7 +140,6 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
private createScopeOverridesIndicator(): SettingIndicator {
// Don't add .setting-indicator class here, because it gets conditionally added later.
const otherOverridesElement = $('span.setting-item-overrides');
otherOverridesElement.tabIndex = 0;
const otherOverridesLabel = new SimpleIconLabel(otherOverridesElement);
return {
element: otherOverridesElement,
Expand Down Expand Up @@ -238,6 +237,7 @@ export class SettingsTreeIndicatorsLabel implements IDisposable {
updateScopeOverrides(element: SettingsTreeSettingElement, onDidClickOverrideElement: Emitter<ISettingOverrideClickEvent>, onApplyFilter: Emitter<string>) {
this.scopeOverridesIndicator.element.innerText = '';
this.scopeOverridesIndicator.element.style.display = 'none';
this.scopeOverridesIndicator.element.tabIndex = 0;
if (element.hasPolicyValue) {
// If the setting falls under a policy, then no matter what the user sets, the policy value takes effect.
this.scopeOverridesIndicator.element.style.display = 'inline';
Expand Down