Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix https://github.com/microsoft/vscode/issues/166082 #167739

Merged
merged 3 commits into from Nov 30, 2022
Merged

fix https://github.com/microsoft/vscode/issues/166082 #167739

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1377351
fix https://github.com/microsoft/vscode/issues/166082
jrieken Nov 30, 2022
0994553
also fix https://github.com/microsoft/vscode/issues/166080
jrieken Nov 30, 2022
c12664c
ops
jrieken Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/vs/editor/contrib/suggest/browser/suggestModel.ts
View file
Open in desktop
Expand Up @@ -669,7 +669,14 @@ export class SuggestModel implements IDisposable {

if (this._completionModel.items.length === 0) {

if (LineContext.shouldAutoTrigger(this._editor) && this._context.leadingWord.endColumn < ctx.leadingWord.startColumn) {
const shouldAutoTrigger = LineContext.shouldAutoTrigger(this._editor);
if (!this._context) {
// shouldAutoTrigger forces tokenization, which can cause pending cursor change events to be emitted, which can cause
// suggestions to be cancelled, which causes `this._context` to be undefined
this.cancel();
}

if (shouldAutoTrigger && this._context.leadingWord.endColumn < ctx.leadingWord.startColumn) {
// retrigger when heading into a new word
this.trigger({ auto: this._context.auto, shy: false }, true);
return;
Expand Down