Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃枈 Include branch name in commit button popup #167827

Merged
merged 2 commits into from Jan 12, 2023
Merged

馃枈 Include branch name in commit button popup #167827

merged 2 commits into from Jan 12, 2023

Conversation

babakks
Copy link
Contributor

@babakks babakks commented Dec 1, 2022 •
edited

Fixes #167545

The branch name, if available, is now displayed on the "Commit" button popup.

Branch name included in the "Commit" button popup

This PR also updates the "Publish Branch" button's popups:

publish-popup
publishing-popup

@babakks
馃枈 Include branch name in commit button popup
128bcd3 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
@babakks
馃枈 Include branch name in "Publish" button popup
f15ee75 
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
jej
jej approved these changes Dec 1, 2022
View reviewed changes
Copy link

@jej jej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@lszomoru lszomoru added the git GIT issues label Jan 12, 2023
@lszomoru lszomoru added this to the January 2023 milestone Jan 12, 2023
@jej
Copy link

jej commented Jan 12, 2023

Great, thanks all.

@lszomoru lszomoru merged commit ea85d0c into microsoft:main Jan 12, 2023
@babakks babakks deleted the show-branch-name-on-commit-btn-popup branch January 12, 2023 20:10
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jej jej jej approved these changes

@jrieken jrieken jrieken approved these changes

@lszomoru lszomoru lszomoru approved these changes

Assignees

@lszomoru lszomoru

Labels
git GIT issues
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

Display branch name in the commit button tooltip
4 participants
@babakks @jej @jrieken @lszomoru