Replace indexOf with includes in terminal

src/vs/platform/terminal/common/terminalEnvironment.ts

@@ -7,7 +7,7 @@ import { OperatingSystem, OS } from 'vs/base/common/platform';
 
 export function escapeNonWindowsPath(path: string): string {
 	let newPath = path;
-	if (newPath.indexOf('\\') !== 0) {
+	if (newPath.includes('\\')) {
 		newPath = newPath.replace(/\\/g, '\\\\');
 	}
 	const bannedChars = /[\`\$\|\&\>\~\#\!\^\*\;\<\"\']/g;

src/vs/platform/terminal/node/terminalProfiles.ts

@@ -295,7 +295,7 @@ async function detectAvailableUnixProfiles(
 	// Add non-quick launch profiles
 	if (includeDetectedProfiles) {
 		const contents = (await fsProvider.readFile('/etc/shells')).toString();
-		const profiles = testPaths || contents.split('\n').filter(e => e.trim().indexOf('#') !== 0 && e.trim().length > 0);
+		const profiles = testPaths || contents.split('\n').filter(e => e.trim().includes('#') && e.trim().length > 0);
 		const counts: Map<string, number> = new Map();
 		for (const profile of profiles) {
 			let profileName = basename(profile);

src/vs/workbench/contrib/terminal/browser/terminalFindWidget.ts

@@ -62,7 +62,7 @@ export class TerminalFindWidget extends SimpleFindWidget {
 	}
 
 	override reveal(): void {
-		const initialInput = this._instance.hasSelection() && this._instance.selection!.indexOf('\n') === -1 ? this._instance.selection : undefined;
+		const initialInput = this._instance.hasSelection() && !this._instance.selection!.includes('\n') ? this._instance.selection : undefined;
 		const xterm = this._instance.xterm;
 		if (xterm && this.inputValue && this.inputValue !== '') {
 			// trigger highlight all matches
@@ -78,7 +78,7 @@ export class TerminalFindWidget extends SimpleFindWidget {
 	}
 
 	override show() {
-		const initialInput = this._instance.hasSelection() && this._instance.selection!.indexOf('\n') === -1 ? this._instance.selection : undefined;
+		const initialInput = this._instance.hasSelection() && !this._instance.selection!.includes('\n') ? this._instance.selection : undefined;
 		super.show(initialInput);
 		this._findWidgetVisible.set(true);
 	}

src/vs/workbench/contrib/terminal/browser/terminalGroupService.ts

@@ -444,7 +444,7 @@ export class TerminalGroupService extends Disposable implements ITerminalGroupSe
 	}
 
 	getGroupForInstance(instance: ITerminalInstance): ITerminalGroup | undefined {
-		return this.groups.find(group => group.terminalInstances.indexOf(instance) !== -1);
+		return this.groups.find(group => group.terminalInstances.includes(instance));
 	}
 
 	getGroupLabels(): string[] {

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

@@ -1857,7 +1857,7 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 	private _setCommandsToSkipShell(commands: string[]): void {
 		const excludeCommands = commands.filter(command => command[0] === '-').map(command => command.slice(1));
 		this._skipTerminalCommands = DEFAULT_COMMANDS_TO_SKIP_SHELL.filter(defaultCommand => {
-			return excludeCommands.indexOf(defaultCommand) === -1;
+			return !excludeCommands.includes(defaultCommand);
 		}).concat(commands);
 	}
 
@@ -2640,16 +2640,16 @@ async function preparePathForShell(originalPath: string, executable: string | un
 			return;
 		}
 
-		const hasSpace = originalPath.indexOf(' ') !== -1;
-		const hasParens = originalPath.indexOf('(') !== -1 || originalPath.indexOf(')') !== -1;
+		const hasSpace = originalPath.includes(' ');
+		const hasParens = originalPath.includes('(') || originalPath.includes(')');
 
 		const pathBasename = path.basename(executable, '.exe');
 		const isPowerShell = pathBasename === 'pwsh' ||
 			title === 'pwsh' ||
 			pathBasename === 'powershell' ||
 			title === 'powershell';
 
-		if (isPowerShell && (hasSpace || originalPath.indexOf('\'') !== -1)) {
+		if (isPowerShell && (hasSpace || originalPath.includes('\''))) {
 			c(`& '${originalPath.replace(/'/g, '\'\'')}'`);
 			return;
 		}
@@ -2677,7 +2677,7 @@ async function preparePathForShell(originalPath: string, executable: string | un
 				}
 			} else {
 				const lowerExecutable = executable.toLowerCase();
-				if (lowerExecutable.indexOf('wsl') !== -1 || (lowerExecutable.indexOf('bash.exe') !== -1 && lowerExecutable.toLowerCase().indexOf('git') === -1)) {
+				if (lowerExecutable.includes('wsl') || (lowerExecutable.includes('bash.exe') && !lowerExecutable.toLowerCase().includes('git'))) {
 					c(backend?.getWslPath(originalPath, 'win-to-unix') || originalPath);
 				} else if (hasSpace) {
 					c('"' + originalPath + '"');

src/vs/workbench/contrib/terminal/browser/xterm/markNavigationAddon.ts

@@ -87,10 +87,10 @@ export class MarkNavigationAddon extends Disposable implements IMarkTracker, ITe
 		}
 
 		if (marker === Boundary.Top) {
-			return this._getMarkers(true).map(e => e.line).indexOf(0) === -1;
+			return !this._getMarkers(true).map(e => e.line).includes(0);
 		}
 
-		return this._getMarkers(true).indexOf(marker) === -1;
+		return !this._getMarkers(true).includes(marker);
 	}
 
 	scrollToPreviousMark(scrollPosition: ScrollPosition = ScrollPosition.Middle, retainSelection: boolean = false, skipEmptyCommands: boolean = false): void {