Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃Ч #171281

Merged
merged 2 commits into from Jan 18, 2023
Merged

馃Ч #171281

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/vs/editor/browser/widget/diffNavigator.ts
Expand Up @@ -240,9 +240,6 @@ export class DiffNavigator extends Disposable implements IDiffNavigator {
return;
}

if (!jumpToChange || !insertedOrModified) {
return;
}
const codeEditor = this._codeEditorService.getActiveCodeEditor();
if (codeEditor && insertedOrModified && this._accessibilityService.isScreenReaderOptimized()) {
codeEditor.setSelection({ startLineNumber: lineNumber, startColumn: 0, endLineNumber: lineNumber, endColumn: Number.MAX_VALUE });
Expand Down
Expand Up @@ -46,7 +46,7 @@ suite('QuickFixAddon', () => {
rows: 30
});
instantiationService.stub(IStorageService, new TestStorageService());
instantiationService.stub(ITerminalContributionService, { quickFixes: new Promise((r) => { r([]); }) } as Partial<ITerminalContributionService>);
instantiationService.stub(ITerminalContributionService, { quickFixes: Promise.resolve([]) } as Partial<ITerminalContributionService>);
instantiationService.stub(ITerminalQuickFixService, { onDidRegisterProvider: new Emitter().event, onDidUnregisterProvider: new Emitter().event, onDidRegisterCommandSelector: new Emitter().event } as Partial<ITerminalQuickFixService>);
instantiationService.stub(IConfigurationService, new TestConfigurationService());
instantiationService.stub(ILabelService, {} as Partial<ILabelService>);
Expand Down
Expand Up @@ -90,7 +90,7 @@ class TestTerminalExtensionService extends TestExtensionService {
class TestTerminalContributionService implements ITerminalContributionService {
_serviceBrand: undefined;
terminalProfiles: readonly IExtensionTerminalProfile[] = [];
quickFixes: Promise<ITerminalCommandSelector[]> = new Promise((r) => { r([]); });
quickFixes: Promise<ITerminalCommandSelector[]> = Promise.resolve([]);
setProfiles(profiles: IExtensionTerminalProfile[]): void {
this.terminalProfiles = profiles;
}
Expand Down