Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support quote link formats when quotes aren't present #171719

Merged
merged 1 commit into from
Jan 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,12 @@ const linkSuffixRegex = new Lazy<RegExp>(() => {
// foo:339
// foo:339:12
// foo 339
// foo 339:12 [#140780]
// foo 339:12 [#140780]
// "foo",339
// "foo",339:12
`(?::| |['"],)${l()}(:${c()})?$`,
// "foo", line 339 [#40468]
// The quotes below are optional [#171652]
// "foo", line 339 [#40468]
// "foo", line 339, col 12
// "foo", line 339, column 12
// "foo":line 339
Expand All @@ -45,7 +46,7 @@ const linkSuffixRegex = new Lazy<RegExp>(() => {
// "foo" on line 339
// "foo" on line 339, col 12
// "foo" on line 339, column 12
`['"](?:, |: ?| on )line ${l()}(, col(?:umn)? ${c()})?$`,
`['"]?(?:, |: ?| on )line ${l()}(, col(?:umn)? ${c()})?$`,
// foo(339)
// foo(339,12)
// foo(339, 12)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,20 @@ const testLinks: ITestLink[] = [
{ link: '\'foo\' on line 339, col 12', suffix: '\' on line 339, col 12', hasRow: true, hasCol: true },
{ link: '\'foo\' on line 339, column 12', suffix: '\' on line 339, column 12', hasRow: true, hasCol: true },

// No quotes
{ link: 'foo, line 339', suffix: ', line 339', hasRow: true, hasCol: false },
{ link: 'foo, line 339, col 12', suffix: ', line 339, col 12', hasRow: true, hasCol: true },
{ link: 'foo, line 339, column 12', suffix: ', line 339, column 12', hasRow: true, hasCol: true },
{ link: 'foo:line 339', suffix: ':line 339', hasRow: true, hasCol: false },
{ link: 'foo:line 339, col 12', suffix: ':line 339, col 12', hasRow: true, hasCol: true },
{ link: 'foo:line 339, column 12', suffix: ':line 339, column 12', hasRow: true, hasCol: true },
{ link: 'foo: line 339', suffix: ': line 339', hasRow: true, hasCol: false },
{ link: 'foo: line 339, col 12', suffix: ': line 339, col 12', hasRow: true, hasCol: true },
{ link: 'foo: line 339, column 12', suffix: ': line 339, column 12', hasRow: true, hasCol: true },
{ link: 'foo on line 339', suffix: ' on line 339', hasRow: true, hasCol: false },
{ link: 'foo on line 339, col 12', suffix: ' on line 339, col 12', hasRow: true, hasCol: true },
{ link: 'foo on line 339, column 12', suffix: ' on line 339, column 12', hasRow: true, hasCol: true },

// Parentheses
{ link: 'foo(339)', suffix: '(339)', hasRow: true, hasCol: false },
{ link: 'foo(339,12)', suffix: '(339,12)', hasRow: true, hasCol: true },
Expand Down