Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output Panel issues with Telemetry and Extension Telemetry channels #171757

Closed
luabud opened this issue Jan 19, 2023 · 11 comments · Fixed by #172032
Closed

Output Panel issues with Telemetry and Extension Telemetry channels #171757

luabud opened this issue Jan 19, 2023 · 11 comments · Fixed by #172032
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Milestone

Comments

@luabud
Copy link
Member

luabud commented Jan 19, 2023

Does this issue occur when all extensions are disabled?: Yes

Version: 1.75.0-insider (user setup)
Commit: 5ae522f
Date: 2023-01-19T14:51:00.913Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Windows_NT x64 10.0.22621
Sandboxed: Yes

Steps to Reproduce:

  1. Set log level to trace
  2. Open the output window

There are a couple of issues here:
1 - The background of the channel picker seems to be transparent now, which makes it hard to read:
image

2 - The name of the Extension Telemetry channel has changed to the log file path:

image

3 - The Telemetry channel seems to be completely missing

image

For contrast, this is how it looks in VS Code 1.74.3:

image

@Tumisang77ll
Copy link

0723796629

@sandy081
Copy link
Member

I have done some fixes last week and I assume they could have fixed the missing or wrong labels. Can you please try with the latest insiders and let me know if you can still repro?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Jan 23, 2023
@sbatten
Copy link
Member

sbatten commented Jan 23, 2023

@sandy081 label seems fixed but the telemetry channel is still missing

@lramos15
Copy link
Member

For me the extension host telemetry log still has a bad path too, I haven't made any changes here so I think this is caused by output channel changes
image

@sandy081
Copy link
Member

@sbatten Are you not only seeing the telemetry channel, but also extension telemetry channel?

@lramos15 Yours might be a glitch, can you please restart and try?

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug log VS Code log issues and removed info-needed Issue requires more information from poster labels Jan 23, 2023
@sandy081 sandy081 added this to the January 2023 milestone Jan 23, 2023
@lramos15
Copy link
Member

@sandy081 Restart doesn't seem to do anything. Should I delete the log file from my VS Code install path?

@sandy081
Copy link
Member

Which version of insiders are you on?

@lramos15
Copy link
Member

Which version of insiders are you on?

Version: 1.75.0-insider (Universal)
Commit: f1b0923
Date: 2023-01-23T11:52:31.652Z
Electron: 19.1.9
Chromium: 102.0.5005.194
Node.js: 16.14.2
V8: 10.2.154.23-electron.0
OS: Darwin x64 22.2.0
Sandboxed: No

sandy081 added a commit that referenced this issue Jan 23, 2023
@sandy081
Copy link
Member

@lramos15 May I know if you can repro it while running out of sources?

@sandy081
Copy link
Member

I provided a fix for telemetry log not being shown.

@lramos15 Lets try to track yours separately

@sandy081
Copy link
Member

Understood the bug and added the fix to the PR.

lramos15 pushed a commit that referenced this issue Jan 23, 2023
* Fix #171757

* complete fix
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jan 23, 2023
TylerLeonhardt pushed a commit that referenced this issue Jan 23, 2023
* Fix #171757

* complete fix
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jan 24, 2023
@jrieken jrieken added the verified Verification succeeded label Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders log VS Code log issues verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants