-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #171757 #172032
Fix #171757 #172032
Conversation
this._outputLogger.info('Below are logs for extension telemetry events sent to the telemetry output channel API once the log level is set to trace.'); | ||
this._outputLogger.info('==========================================================='); | ||
} | ||
|
||
private updateLoggerVisibility(): void { | ||
this.loggerService.setVisibility(this.extHostTelemetryLogFile, this._level !== TelemetryLevel.NONE && this.loggerService.getLogLevel() === LogLevel.Trace); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would want to show the log even when telemetry level is none because we want to show the users that nothing is flowing. We'd want to use the same supportsTelemetry
function as before as that's checking for --disable-telemetry
and things of that nature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning this up! I'll make another PR to address some telemetry specific pieces
Fix #171757