Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include galleryExtension for publisher check #172338

Merged
merged 1 commit into from Jan 25, 2023
Merged

Include galleryExtension for publisher check #172338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/vs/workbench/contrib/localization/electron-sandbox/localization.contribution.ts
View file
Open in desktop
Expand Up @@ -13,7 +13,6 @@ import * as platform from 'vs/base/common/platform';
import { IExtensionManagementService, IExtensionGalleryService, InstallOperation, ILocalExtension, InstallExtensionResult, DidUninstallExtensionEvent } from 'vs/platform/extensionManagement/common/extensionManagement';
import { INotificationService, NeverShowAgainScope } from 'vs/platform/notification/common/notification';
import Severity from 'vs/base/common/severity';
import { IHostService } from 'vs/workbench/services/host/browser/host';
import { IStorageService, StorageScope, StorageTarget } from 'vs/platform/storage/common/storage';
import { VIEWLET_ID as EXTENSIONS_VIEWLET_ID, IExtensionsViewPaneContainer } from 'vs/workbench/contrib/extensions/common/extensions';
import { minimumTranslatedStrings } from 'vs/workbench/contrib/localization/electron-sandbox/minimalTranslations';
Expand Down Expand Up @@ -41,7 +40,6 @@ export class LocalizationWorkbenchContribution extends Disposable implements IWo
@INotificationService private readonly notificationService: INotificationService,
@ILocaleService private readonly localeService: ILocaleService,
@IProductService private readonly productService: IProductService,
@IHostService private readonly hostService: IHostService,
@IStorageService private readonly storageService: IStorageService,
@IExtensionManagementService private readonly extensionManagementService: IExtensionManagementService,
@IExtensionGalleryService private readonly galleryService: IExtensionGalleryService,
Expand Down Expand Up @@ -191,9 +189,9 @@ export class LocalizationWorkbenchContribution extends Disposable implements IWo
id: locale,
label: languageName,
extensionId: extensionToInstall?.identifier.id,
galleryExtension: extensionToInstall
// The user will be prompted if they want to install the language pack before this.
}, true);
await this.hostService.restart();
}
};

Expand Down