Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: fix test jumping from test explorer view to File explorer #173225

Merged
merged 1 commit into from Feb 3, 2023
Merged

testing: fix test jumping from test explorer view to File explorer #173225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/vs/workbench/contrib/testing/browser/testingProgressUiService.ts
View file
Open in desktop
Expand Up @@ -10,14 +10,13 @@ import { localize } from 'vs/nls';
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
import { createDecorator, IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
import { ProgressLocation, UnmanagedProgress } from 'vs/platform/progress/common/progress';
import { ViewContainerLocation } from 'vs/workbench/common/views';
import { IViewsService } from 'vs/workbench/common/views';
import { AutoOpenTesting, getTestingConfiguration, TestingConfigKeys } from 'vs/workbench/contrib/testing/common/configuration';
import { Testing } from 'vs/workbench/contrib/testing/common/constants';
import { TestResultState } from 'vs/workbench/contrib/testing/common/testTypes';
import { isFailedState } from 'vs/workbench/contrib/testing/common/testingStates';
import { LiveTestResult, TestResultItemChangeReason, TestStateCount } from 'vs/workbench/contrib/testing/common/testResult';
import { ITestResultService } from 'vs/workbench/contrib/testing/common/testResultService';
import { IPaneCompositePartService } from 'vs/workbench/services/panecomposite/browser/panecomposite';
import { TestResultState } from 'vs/workbench/contrib/testing/common/testTypes';

export interface ITestingProgressUiService {
readonly _serviceBrand: undefined;
Expand All @@ -35,7 +34,7 @@ export class TestingProgressTrigger extends Disposable {
@ITestResultService resultService: ITestResultService,
@ITestingProgressUiService progressService: ITestingProgressUiService,
@IConfigurationService private readonly configurationService: IConfigurationService,
@IPaneCompositePartService private readonly paneCompositeService: IPaneCompositePartService,
@IViewsService private readonly viewsService: IViewsService,
) {
super();

Expand Down Expand Up @@ -83,7 +82,7 @@ export class TestingProgressTrigger extends Disposable {
}

private openTestView() {
this.paneCompositeService.openPaneComposite(Testing.ViewletId, ViewContainerLocation.Sidebar);
this.viewsService.openView(Testing.ExplorerViewId, false);
}
}

Expand Down