Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable audio cues to be played in parallel when playAudioCues is called #173326

Merged
merged 2 commits into from
Feb 3, 2023
Merged

enable audio cues to be played in parallel when playAudioCues is called #173326

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7e83ed
fix #172523
meganrogge Feb 3, 2023
441ce89
Merge branch 'main' into merogge/q
meganrogge Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/platform/audioCues/browser/audioCueService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export class AudioCueService extends Disposable implements IAudioCueService {
public async playAudioCues(cues: AudioCue[]): Promise<void> {
// Some audio cues might reuse sounds. Don't play the same sound twice.
const sounds = new Set(cues.filter(cue => this.isEnabled(cue)).map(cue => cue.sound));
await Promise.all(Array.from(sounds).map(sound => this.playSound(sound)));
await Promise.all(Array.from(sounds).map(sound => this.playSound(sound, true)));
}

private getVolumeInPercent(): number {
Expand Down