Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes https://github.com/microsoft/monaco-editor/issues/3090 #173688

Merged
merged 1 commit into from Feb 7, 2023
Merged

Fixes https://github.com/microsoft/monaco-editor/issues/3090 #173688

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/vs/editor/common/languages/languageConfigurationRegistry.ts
View file
Open in desktop
Expand Up @@ -127,7 +127,9 @@ function computeConfig(

if (!languageConfig) {
if (!languageService.isRegisteredLanguageId(languageId)) {
throw new Error(`Language id "${languageId}" is not configured nor known`);
// this happens for the null language, which can be returned by monarch.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean monaco?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

monarch, which is the monaco tokenizer (not textmate)

// Instead of throwing an error, we just return a default config.
return new ResolvedLanguageConfiguration(languageId, {});
}
languageConfig = new ResolvedLanguageConfiguration(languageId, {});
}
Expand Down